feat(bash-completion): prevent space after profile completion .
#405
Conversation
WalkthroughThe changes involve modifications to the Bash completion function for Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Shell
participant _resticprofile
User->>Shell: Request completion for resticprofile
Shell->>_resticprofile: Call _resticprofile function
_resticprofile->>_resticprofile: Check last character of COMPREPLY
alt Last character is not a period
_resticprofile->>Shell: Execute compopt +o nospace
end
_resticprofile->>Shell: Return completion suggestions
Shell->>User: Display completion suggestions
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- contrib/completion/bash-completion.sh (1 hunks)
🧰 Additional context used
🪛 Shellcheck
contrib/completion/bash-completion.sh
[error] 65-65: Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @).
(SC2199)
🔇 Additional comments (1)
contrib/completion/bash-completion.sh (1)
72-72: Appropriate update to the completion registration.The addition of the
-o nospaceoption to the completion registration is a good complement to the new conditional logic. This ensures that spaces are not automatically added after completions by default, allowing the new logic to control space insertion more precisely.
When tab completing a profile, an unwanted space is added after the period `.`, necessitating hitting backspace before further completions can be accessed. The implementation here was based on the following resources: * https://stackoverflow.com/a/66151065 - Add spaces to the end of some Bash autocomplete options, but not to others? * https://stackoverflow.com/a/19271994 - How can I check the last character in a string in bash? An alternative to checking for the last character is using regex: * https://stackoverflow.com/a/21425089 - How to check if the last string character equals '*' in Bash?
myii
force-pushed
the
feat/prevent-space-after-profile-bash-completion
branch
from
f47f408 to
cc68b18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 72.30% 72.30%
=======================================
Files 127 127
Lines 12940 12940
=======================================
Hits 9356 9356
Misses 3158 3158
Partials 426 426
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
When tab completing a profile, an unwanted space is added after the period
., necessitating hitting backspace before further completions can be accessed.The implementation here was based on the following resources:
An alternative to checking for the last character is using regex: